Normalize openapi plugin secret/connection refs#519
Closed
RhysSullivan wants to merge 1 commit intors/normalize-graphqlfrom
Closed
Normalize openapi plugin secret/connection refs#519RhysSullivan wants to merge 1 commit intors/normalize-graphqlfrom
RhysSullivan wants to merge 1 commit intors/normalize-graphqlfrom
Conversation
7 tasks
Owner
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 4, 2026
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 22e0bb7 | Commit Preview URL Branch Preview URL |
May 05 2026, 06:27 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 22e0bb7 | May 05 2026, 06:28 PM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/storage-core
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-google-discovery
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
force-pushed
the
rs/normalize-graphql
branch
from
fc4e787 to
8df7c7b
Compare
RhysSullivan
force-pushed
the
rs/normalize-openapi
branch
2 times, most recently
from
5a7fa76 to
8d1c6eb
Compare
RhysSullivan
force-pushed
the
rs/normalize-graphql
branch
from
8df7c7b to
2e41ee2
Compare
Move secret/connection references out of the JSON columns on
openapi_source and openapi_source_binding into:
- openapi_source_binding gains kind/secret_id/connection_id/text_value
columns (replacing the discriminated-union json value)
- openapi_source_query_param: child table for query_params, mirrors
graphql_source_query_param shape
- openapi_source_spec_fetch_header / spec_fetch_query_param: child
tables for invocation_config.specFetchCredentials.{headers,queryParams}
Drops openapi_source.query_params and openapi_source.invocation_config
JSON columns. headers and oauth2 stay JSON because they hold slot
names rather than direct refs — the slots resolve through bindings,
which ARE normalized.
Plugin gains usagesForSecret / usagesForConnection that fan out across
all four locations in one indexed SELECT each. secrets.remove now
correctly RESTRICTs when an openapi binding still uses the secret.
Migration 0008 backfills via json_extract / json_each, then drops the
old columns. Three migration tests cover the backfill from a
hand-seeded pre-migration DB; two plugin-level tests cover usage
fan-out and remove RESTRICT.
RhysSullivan
force-pushed
the
rs/normalize-graphql
branch
from
2e41ee2 to
57a1a41
Compare
RhysSullivan
force-pushed
the
rs/normalize-openapi
branch
from
8d1c6eb to
22e0bb7
Compare
Owner
Author
|
Consolidated into #521 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move secret/connection references out of the JSON columns on
openapi_source and openapi_source_binding into:
columns (replacing the discriminated-union json value)
graphql_source_query_param shape
tables for invocation_config.specFetchCredentials.{headers,queryParams}
Drops openapi_source.query_params and openapi_source.invocation_config
JSON columns. headers and oauth2 stay JSON because they hold slot
names rather than direct refs — the slots resolve through bindings,
which ARE normalized.
Plugin gains usagesForSecret / usagesForConnection that fan out across
all four locations in one indexed SELECT each. secrets.remove now
correctly RESTRICTs when an openapi binding still uses the secret.
Migration 0008 backfills via json_extract / json_each, then drops the
old columns. Three migration tests cover the backfill from a
hand-seeded pre-migration DB; two plugin-level tests cover usage
fan-out and remove RESTRICT.